Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Remove implicit nullable types #43883

Closed
wants to merge 3 commits into from

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Aug 5, 2024

Summary of Changes

In PHP 8.4 will implicit nullable types being deprecated. This pr changes that syntax in core by adding the new rule nullable_type_declaration_for_default_null_value to our CS fixer definition.

.php-cs-fixer.dist.php Outdated Show resolved Hide resolved
@heelc29
Copy link
Contributor

heelc29 commented Aug 5, 2024

Please also update doc block
See #43323

@laoneo
Copy link
Member Author

laoneo commented Aug 6, 2024

Closing this in favor of #43323.

@laoneo laoneo closed this Aug 6, 2024
@laoneo laoneo deleted the nullable branch August 6, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants